Allow all CORS requests when running locally with plugin #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make it easy to interact with a local chain through browser extensions without having to deal with HTTP proxies.
Explanation of Changes
Rather than introducing a new flag I lumped it with the existing
--pluginflag, as for most cases we'll want to use them in tandem. Should it turn out to be useful separately we can always move it to its own flag.Testing
Similar to the setup described in #442, but now we don't need a HTTP proxy and can directly point the browser extension to the local address and port.
Related PRs and Issues
N.A.