Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor wasm storage module collections #271

Merged
merged 7 commits into from
May 25, 2024
Merged

refactor: refactor wasm storage module collections #271

merged 7 commits into from
May 25, 2024

Conversation

hacheigriega
Copy link
Member

@hacheigriega hacheigriega commented May 17, 2024 •
edited
Loading

Fixing some issues introduced during the migration to collections.

  • Fix the issue where we add wasm type prefix unnecessarily.
  • Update field names so they are clearer.
  • Remove unnecessary functions.

@hacheigriega hacheigriega changed the title feat: Adding Tally VM refactor: refactor wasm storage module collections May 17, 2024
@hacheigriega hacheigriega marked this pull request as ready for review May 17, 2024 16:47
@hacheigriega hacheigriega requested a review from DeshErBojhaa May 17, 2024 16:47
@Thomasvdam
Copy link
Member

This also includes a bunch of the tally VM stuff, is that intended?

@hacheigriega
Copy link
Member Author

This also includes a bunch of the tally VM stuff, is that intended?

removed the tally vm import, which is not relevant here!

DeshErBojhaa
DeshErBojhaa approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@DeshErBojhaa DeshErBojhaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great work!!

@hacheigriega hacheigriega merged commit e50eb55 into main May 25, 2024
8 of 10 checks passed
@hacheigriega hacheigriega deleted the hy/tally branch May 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasvdam Thomasvdam Thomasvdam left review comments

@DeshErBojhaa DeshErBojhaa DeshErBojhaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacheigriega @Thomasvdam @DeshErBojhaa