Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Default Time For vesting time in CSV Script #241

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Apr 9, 2024

Motivation

So if in the CSV file they do not provide the start time wich aligns more the traditional vesting time command.

Explanation of Changes

Script now:

  • checks the CSV and genesis files exist.
  • stores the Genesis time before reading the CSV.
  • Checks if the vesting amount is set; if the start time is not set, it is to the genesis time.

Testing

Added a new line to the example csv to test this with.

Related PRs and Issues

N/A

@gluax gluax self-assigned this Apr 9, 2024
@gluax gluax changed the title Feat: Add Default Time For vesting time. Feat: Add Default Time For vesting time in CSV Script Apr 9, 2024
Copy link
Member

@hacheigriega hacheigriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks Jon

@gluax gluax merged commit b6974d3 into main Apr 10, 2024
16 of 17 checks passed
@gluax gluax deleted the feat/csv-allow-no-start-time branch April 10, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants