Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable wasm-storage module #235

Merged
merged 8 commits into from
May 2, 2024
Merged

Conversation

hacheigriega
Copy link
Member

@hacheigriega hacheigriega commented Apr 2, 2024

Explanation of Changes

Work by @FranklinWaller - I will confirm the proxy contract instantiation and execution implementation before merging.

This PR reenables wasm-storage module to support storing overlay wasms (through governance) and data request wasms. This module also supports proxy contract registry.

deploy_contracts.sh Outdated Show resolved Hide resolved
@hacheigriega hacheigriega marked this pull request as draft April 3, 2024 15:43
@hacheigriega
Copy link
Member Author

hacheigriega commented Apr 3, 2024

Converted to draft to focus on mainnet launch for now. Before merging, make sure the following:

  • The proxy contract creator should be the sender of the instantiate-and-register-proxy-contract or store-overlay-wasm transaction (double-check authority flag during transaction creation).
  • Merge to a separate branch.
  • The contract deployment script runs successfully and is placed in the proper location.

Copy link
Member

@mariocao mariocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is a draft PR, just a gentle reminder to reword the "WIP" commit. 😅

@hacheigriega hacheigriega force-pushed the chore/deploy-contracts branch from 1e6b058 to 72492f5 Compare April 29, 2024 14:35
@hacheigriega hacheigriega marked this pull request as ready for review April 29, 2024 18:21
@hacheigriega hacheigriega force-pushed the chore/deploy-contracts branch from 4f35796 to f0a41fa Compare April 29, 2024 18:26
@hacheigriega
Copy link
Member Author

Ready to be merged, but wanted to double check two things:

  • The proxy contract currently only allows the contract creator to execute its functions like set_staking and set_data_requests. Therefore, I changed the instantiation function to use the admin (the account specified in a flag for instantiate-and-register-proxy-contract tx - usually the sender of the tx) as the creator. Before, the creator was set as the gov module account.
  • Should we push this to main or should we create a separate branch for Euclid (testnet with DR)?

Cc: @mariocao

@hacheigriega hacheigriega requested a review from mariocao April 30, 2024 18:06
README.md Outdated Show resolved Hide resolved
@hacheigriega hacheigriega force-pushed the chore/deploy-contracts branch from cf07c95 to d22bddb Compare May 2, 2024 14:20
@hacheigriega hacheigriega merged commit d22bddb into main May 2, 2024
9 of 10 checks passed
@hacheigriega hacheigriega deleted the chore/deploy-contracts branch May 2, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants