-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable wasm-storage module #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
approved these changes
Apr 3, 2024
Converted to draft to focus on mainnet launch for now. Before merging, make sure the following:
|
mariocao
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is a draft PR, just a gentle reminder to reword the "WIP" commit. 😅
hacheigriega
force-pushed
the
chore/deploy-contracts
branch
from
April 29, 2024 14:35
1e6b058
to
72492f5
Compare
hacheigriega
force-pushed
the
chore/deploy-contracts
branch
from
April 29, 2024 18:26
4f35796
to
f0a41fa
Compare
Ready to be merged, but wanted to double check two things:
Cc: @mariocao |
mariocao
reviewed
May 1, 2024
mariocao
approved these changes
May 1, 2024
hacheigriega
force-pushed
the
chore/deploy-contracts
branch
from
May 2, 2024 14:20
cf07c95
to
d22bddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
Work by @FranklinWaller - I will confirm the proxy contract instantiation and execution implementation before merging.
This PR reenables wasm-storage module to support storing overlay wasms (through governance) and data request wasms. This module also supports proxy contract registry.