Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Genesis Accounts From CSV #232

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Mar 28, 2024

Motivation

An easy way to add genesis accounts given a csv file.

Explanation of Changes

  • Submodule the new seda scripts repo.
  • Added a script to parse CSV and add the Genesis accounts.
  • Added an example CSV file.

Any errors that occur give the failed CSV entry and the reason for failure written to the file specified.

Testing

Tested a lot by running and trying locally.

Related PRs and Issues

Closes #224.

Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally not a big fan of submodules but I think it makes sense here. Maybe add a line somewhere to explain how to update/initialise submodules given it’s not a super common action?
The scripts repo is private, maybe we should mention that too.

Copy link
Member

@hacheigriega hacheigriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about submodules. Interesting!

@gluax gluax merged commit c325dc3 into main Apr 2, 2024
16 of 17 checks passed
@gluax gluax deleted the feat/genesis-accounts-from-csv branch April 2, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Create script for adding genesis accounts
3 participants