Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
The main thing I'm unsure about is how we pass the codec around, is this idiomatic Golang or is there a cleaner way to do this?
Made a small improvement in the
ListenFinalizeBlock
handler by preallocating the slice since we should know up front how long it is going to be.Testing
You can 'just' set up the plugin, queue emulator, and start a local node. Once it's running submit a transaction (for the example I used a bank transfer, but I have tried a bunch of different ones). You should start see a
"tx"
message getting added to the queue:Just the message:
Related PRs and Issues
Closes: #223