Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup TODO comments #220

Merged
merged 1 commit into from
Mar 20, 2024
Merged

chore: cleanup TODO comments #220

merged 1 commit into from
Mar 20, 2024

Conversation

hacheigriega
Copy link
Member

Motivation

Cleaning up TODO comments.

  • Avoid writing TODO comments as much as possible.
  • Add an issue if possible like TODO(#220)
  • Rename TO-DO to TODO

@hacheigriega hacheigriega requested a review from mariocao March 19, 2024 19:55
mariocao
mariocao approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mariocao mariocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@hacheigriega hacheigriega merged commit 1b64ee5 into main Mar 20, 2024
16 of 17 checks passed
@hacheigriega hacheigriega deleted the hy/cleanup branch March 20, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocao mariocao mariocao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacheigriega @mariocao