Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel simulation workflows when an update is pushed #216

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

Thomasvdam
Copy link
Member

Motivation

This saves some compute when frequently updating PRs.

Explanation of Changes

I used the same concurrency key that most other workflows are using.

Testing

Did not test, but since this works for other workflows I'm fairly confident it will work. Famous last words...

Related PRs and Issues

See the GHA runs for #214, simulation was not cancelled while test and interchaintest were when updates were pushed in quick succession.

@Thomasvdam Thomasvdam requested a review from a team March 19, 2024 10:22
Copy link
Member

@hacheigriega hacheigriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!!

A side question: I've been trying to fix the duplicate CI runs in the main of this repo. Do you think we should update the yml files to:

on:
  pull_request:
    push:
      branches:
        - main

as in the explorer ymls?

@Thomasvdam
Copy link
Member Author

Thomasvdam commented Mar 19, 2024

Which ones are running twice? With that config we can have tasks run only for PRs and not after a merge.

As discussed we'll add the update to only run certain workflows on PRs to this PR.

@hacheigriega
Copy link
Member

Done!

@Thomasvdam Thomasvdam force-pushed the fix/simulations-ci-concurrency branch from ff6b728 to e45cdd6 Compare March 19, 2024 18:38
@Thomasvdam Thomasvdam merged commit e45cdd6 into main Mar 19, 2024
9 of 10 checks passed
@Thomasvdam Thomasvdam deleted the fix/simulations-ci-concurrency branch March 19, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants