Fix(staking): autocli flag panic fix #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
requested review from
jamesondh,
Thomasvdam,
FranklinWaller,
mariocao,
hacheigriega and
mennatnaga
hacheigriega
approved these changes
Mar 25, 2024
gluax
force-pushed
the
fix/custom-staking-autocli
branch
from
ba9cc9f to
970a735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix the
autocliruntime panic issue.Explanation of Changes
Tell autocli to use the positional height for
Historicalnfoinstead of our height flag. Or that's what I think I did lol.Testing
I compiled and tested that the panic still doesn't happen with these changes.
But idk what else may have changed to the cli for me doing this?
Related PRs and Issues
Closes #199