Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: advise against Horcrux #204

Merged
merged 3 commits into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,27 +85,33 @@ When connecting externally, choose a trustworthy node operator. Unscrupulous ope
### Running the Node Yourself

```
<!-- rename the downloaded binary to a simpler name -->
mv sedad-${ARCH} sedad
<!-- mv sedad-amd64 sedad -->
<!-- mv sedad-arm64 sedad -->

<!-- make the downloaded binary executable -->
chmod +x sedad-${ARCH}
<!-- chmod +x sedad-amd64 -->
<!-- chmod +x sedad-arm64 -->
chmod +x sedad


<!-- reset the chain -->
./sedad-${ARCH} tendermint unsafe-reset-all
./sedad tendermint unsafe-reset-all
rm -rf ~/.sedad || true

<!-- create your operator key -->
./sedad-${ARCH} keys add <key-name>
./sedad keys add <key-name>

<!-- initialize your node and join the network (optionally with an existing key using the recover flag) -->
./sedad-${ARCH} join <moniker> --network <devnet|testnet> [--recover]
./sedad join <moniker> --network <devnet|testnet> [--recover]

<!-- start your node -->
./sedad-${ARCH} start
./sedad start
```

### Creating a validator

We advise you against using Horcrux signing service as several validators have reported unstable signing. We suspect Horcrux is not yet stable under Cosmos SDK version 0.50.

In order to create your validator, make sure you are fully synced to the latest block height of the network.

You can check by using the following command:
Expand All @@ -124,7 +130,7 @@ Create a `validator.json` file and fill in the create-validator tx parameters:

```
{
"pubkey": $(./sedad-${ARCH} tendermint show-validator),
"pubkey": $(./sedad tendermint show-validator),
"amount": "1000000000000000000000000000000000aseda",
"moniker": "the moniker for your validator",
"identity": "optional identity signature (ex. UPort or Keybase) This key will be used by block explorers to identify the validator.",
Expand All @@ -141,13 +147,13 @@ Create a `validator.json` file and fill in the create-validator tx parameters:
Use the following command to create a validator:

```
./sedad-${ARCH} tx staking create-validator validator.json --from <wallet-name> --chain-id <target-chain> --node <node-url>
./sedad tx staking create-validator validator.json --from <wallet-name> --chain-id <target-chain> --node <node-url>
```

That’s it now you can find your validator operator address using the following command, which you can advertise to receive delegations:

```
./sedad-${ARCH} keys show <wallet-name> --bech val -a
./sedad keys show <wallet-name> --bech val -a
```

### Running the Node with Cosmovisor
Expand Down Expand Up @@ -177,7 +183,7 @@ source ~/.profile
Initialize Cosmovisor with the chain binary and start the node.

```
cosmovisor init sedad-${ARCH}
cosmovisor init sedad
cosmovisor run start
```

Expand Down
1 change: 0 additions & 1 deletion x/vesting/keeper/msg_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ func (m msgServer) CreateVestingAccount(goCtx context.Context, msg *types.MsgCre
func (m msgServer) Clawback(goCtx context.Context, msg *types.MsgClawback) (*types.MsgClawbackResponse, error) {
ctx := sdk.UnwrapSDKContext(goCtx)

// NOTE: errors checked during msg validation
vestingAccAddr := sdk.MustAccAddressFromBech32(msg.AccountAddress)
funderAddr := sdk.MustAccAddressFromBech32(msg.FunderAddress)

Expand Down
Loading