refactor: Migrate to Collections #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a slight chance this is relevant or helpful for the failing simulation tests. I will address this PR in a few days. |
hacheigriega
changed the title
hacheigriega
force-pushed
the
jay/migrate-to-collections
branch
from
47f9832 to
4636f64
Compare
hacheigriega
requested changes
May 2, 2024
DeshErBojhaa
force-pushed
the
jay/migrate-to-collections
branch
from
b529c15 to
a4b89d1
Compare
SetProxyContractRegistry and GetProxyContractRegistry can be easily replaced with the underlying collection's Get and Set methods
GetParams and SetParams can be easily replaced with the underlying collection's Get and Set methods
DeshErBojhaa
force-pushed
the
jay/migrate-to-collections
branch
from
0a2baff to
82f7637
Compare
hacheigriega
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR migrates the custom modules to Collections, a new module state management system introduced in SDK v0.50. This is a fundamental change to how we think of state in modules.
Related
#116