Fix: Lint Errors #178
Merged
Fix: Lint Errors #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jim380
approved these changes
Jan 26, 2024
jim380
force-pushed
the
fix/lint-errors
branch
from
a8008d9 to
6e23aff
Compare
jim380
force-pushed
the
fix/lint-errors
branch
from
acfcef1 to
4a5e189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix all the lint errors.
Explanation of Changes
I tried my best to fix all the lint issues; however, here are some notes:
log.Fatalvspanic.I tried to look at the function for context, but please double-check.unused, but maybe we can remove some of it or add better explanations on why it's unused.I think everything else was fairly straightforward.
Testing
I am about to see if the CI passes still lol.
Related PRs and Issues
Closes #169
(Link your related PRs and Issues here)