Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Protobuf Lint CI #151

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Feat: Protobuf Lint CI #151

merged 9 commits into from
Feb 2, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Jan 8, 2024

Motivation

To lint the protobuf files.

Explanation of Changes

  1. Added a lint and fmt check for protobuf only in a new lint job in test.yml.
  2. Fixed all the linter issues with the protobuf.
    I tried my best to comment on all the protobuf appropriately(required by the linter), but lmk if there's some way to better comment it.
  3. Regenerated the go files from the protobuf.

Testing

Tested in my private repo that the CI works(passes and fails) as expected.

Related PRs and Issues

Closes #64

@gluax
Copy link
Contributor Author

gluax commented Jan 8, 2024

Here's the lint job for those curious :D.

@hacheigriega
Copy link
Member

hacheigriega commented Jan 8, 2024

This conflicts with PR #149

@jim380
Copy link
Contributor

jim380 commented Jan 8, 2024

I'd say this PR is complementary to #149 as 149 doesn't handle proto lint. Though I have not seen many chains putting proto lint in CI.

@gluax gluax changed the title Feat: Lint CI Feat: Protobuf Lint CI Jan 23, 2024
@gluax gluax changed the base branch from main to fix/lint-errors January 23, 2024 22:14
Base automatically changed from fix/lint-errors to main January 26, 2024 23:17
@gluax gluax merged commit e46c733 into main Feb 2, 2024
15 checks passed
@gluax gluax deleted the feat/lint-ci branch February 2, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Use buf for linting proto files
5 participants