feat(staker): add eligibility check #239
Conversation
| pub fn is_eligible_for_dr(deps: Deps, dr_id: [u8; 32], public_key: PublicKey) -> Result<bool, ContractError> { | ||
| let data_request = may_load_request(deps.storage, &dr_id)?.unwrap(); |
There was a problem hiding this comment.
We should clean up these unwraps, we can do load_request here instead.
But for the other expects/unwraps we should also clean them up. Otherwise this function returns a Result for no reason since we don't bubble up errors anywhere and instead panic.
| let stakers = STAKERS.stakers.keys_raw(deps.storage, None, None, Order::Ascending); | ||
| let all_stakers = stakers.collect::<Vec<Vec<u8>>>(); | ||
|
|
||
| let stakers_length: u64 = all_stakers.len().try_into().expect("cannot convert to u64"); | ||
| let (staker_index, _) = all_stakers | ||
| .iter() | ||
| .enumerate() | ||
| .find(|(_, pk)| public_key.as_ref() == pk.as_slice()) | ||
| .expect("Could not find staker"); |
There was a problem hiding this comment.
We shouldn't have to iterate the entire staker pool to find one or ask for the length? Ideally, if we need length of Staker pool we should start storing it on the type. We could also, then return a Staker's index when asking for one.
This staker index would also be non-deterministic since its from the cw-storage-plus not our EnumerableSet type which has swap remove. Every time we run raw_keys the order would be different.
Motivation
Add eligibility check to the query.
NOTICE: This function is more of a suggestion than an actual check, it helps the round-robin version of the overlay network coordinate with each other. This does not need to be checked at commit level.
Explanation of Changes
Testing
Added a couple extra tests to make sure the round robin mechanism works as expected
Related PRs and Issues
closes #236