Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RHTAP references #96

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

red-hat-konflux[bot]
Copy link

This PR contains the following updates:

Package Change
quay.io/redhat-appstudio-tekton-catalog/task-buildah 3ab8622 -> 93c3180
quay.io/redhat-appstudio-tekton-catalog/task-clair-scan 4d85885 -> f6a5a24
quay.io/redhat-appstudio-tekton-catalog/task-clamav-scan 884697b -> b7d1945
quay.io/redhat-appstudio-tekton-catalog/task-deprecated-image-check 6df3f9a -> c05395f
quay.io/redhat-appstudio-tekton-catalog/task-git-clone 1f84973 -> 45b3ae2
quay.io/redhat-appstudio-tekton-catalog/task-inspect-image 7880c08 -> 3a5d3f6
quay.io/redhat-appstudio-tekton-catalog/task-prefetch-dependencies c7b7f13 -> ca366af
quay.io/redhat-appstudio-tekton-catalog/task-sast-snyk-check ce73b27 -> edd4ba6
quay.io/redhat-appstudio-tekton-catalog/task-sbom-json-check d8d114d -> 0ca48e1
quay.io/redhat-appstudio-tekton-catalog/task-summary 9d43202 -> 243b131

To execute skipped test pipelines write comment /ok-to-test

@red-hat-konflux red-hat-konflux bot force-pushed the rhtap/references/redhat-v0.6.5 branch from b2ad86f to e25e055 Compare October 18, 2023 17:04
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-trusted-app-pipeline[bot]
Once this PR has been reviewed and has the lgtm label, please assign jasonpowr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

Hi @red-hat-trusted-app-pipeline[bot]. Thanks for your PR.

I'm waiting for a securesign member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Oct 18, 2023

/override "verify / license boilerplate check (pull_request)"

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

@lance: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • verify / license boilerplate check (pull_request)

Only the following failed contexts/checkruns were expected:

  • ci/prow/test
  • license boilerplate check
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "verify / license boilerplate check (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Oct 18, 2023

/override "license boilerplate check"

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

@lance: Overrode contexts on behalf of lance: license boilerplate check

In response to this:

/override "license boilerplate check"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Oct 18, 2023

/ok-to-test

@JasonPowr
Copy link

/retest

@JasonPowr
Copy link

JasonPowr commented Oct 19, 2023

For some reason this pr seems to break unit tests, I will investigate

I found the issue, the path for the source code has changed causing the 'go test ./...' cmd to run in a repo without tests, will update the test for scaffolding and anywhere else that needs it

Actually I'm going to mention this in the slack channel to see if this change is intentional as it seems to be affecting the 'deprecated-base-image-check' with the following error

STEP-QUERY-PYXIS

/tekton/scripts/script-0-x6fq5: line 6: syntax error near unexpected token `<'
Unexpected error: Script errored at command: trap 'handle_error' EXIT.
STEP-RUN-CONFTEST

/tekton/scripts/script-1-f892b: line 36: /tekton/results/PYXIS_HTTP_CODE: No such file or directory
{"result":"ERROR","timestamp":"1697705656","note":"Task deprecated-image-check failed: Command conftest failed. For details, check Tekton task log.","namespace":"required_checks","successes":0,"failures":0,"warnings":0}

The change in paths is permanent Im going to merge this then fix the paths

@JasonPowr
Copy link

/retest

@JasonPowr JasonPowr merged commit 1db3955 into redhat-v0.6.5 Oct 19, 2023
Gregory-Pereira pushed a commit to Gregory-Pereira/scaffolding that referenced this pull request Nov 20, 2023
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants