Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline for new ws #75

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

JasonPowr
Copy link

@JasonPowr JasonPowr commented Oct 6, 2023

Enables hermetic builds and unit tests for tekton pipelines in the new ws

Fixes: #79

@JasonPowr
Copy link
Author

@lance

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance
Copy link
Member

lance commented Oct 9, 2023

/ok-to-test

@lance
Copy link
Member

lance commented Oct 9, 2023

/retest

1 similar comment
@lance
Copy link
Member

lance commented Oct 10, 2023

/retest

@lance
Copy link
Member

lance commented Oct 10, 2023

Seeing this for the prefetch-dependencies task on ct-server.

STEP-PREFETCH-DEPENDENCIES

2023-10-10 13:41:02,300 ERROR InvalidInput: 1 validation error for user input\npackages -> 1\n  package path does not exist (or is not a directory): hack/build-assets/certificate-transparency-go-1.1.6
Error: InvalidInput: 1 validation error for user input
packages -> 1
  package path does not exist (or is not a directory): hack/build-assets/certificate-transparency-go-1.1.6

@JasonPowr
Copy link
Author

Seeing this for the prefetch-dependencies task on ct-server.

STEP-PREFETCH-DEPENDENCIES

2023-10-10 13:41:02,300 ERROR InvalidInput: 1 validation error for user input\npackages -> 1\n  package path does not exist (or is not a directory): hack/build-assets/certificate-transparency-go-1.1.6
Error: InvalidInput: 1 validation error for user input
packages -> 1
  package path does not exist (or is not a directory): hack/build-assets/certificate-transparency-go-1.1.6

Ah i see the issue its not under hack/build-assets/certificate-transparency-go-1.1.6 its its under hack/build-assets, will follow up with a fix

@lance
Copy link
Member

lance commented Oct 11, 2023

/retest

2 similar comments
@lance
Copy link
Member

lance commented Oct 13, 2023

/retest

@JasonPowr
Copy link
Author

/retest

@JasonPowr JasonPowr force-pushed the update-pipeline-for-new-ws branch from 37a5813 to 170a4ea Compare October 16, 2023 09:03
@JasonPowr
Copy link
Author

/retest

@lance
Copy link
Member

lance commented Oct 16, 2023

Still something going on with ct-server it seems.

[build] [1/2] STEP 5/8: COPY hack/build-assets/certificate-transparency-go-1.1.6/certificate-transparency-go-1.1.6.tar.gz /ct_server/
[build] Error: building at STEP "COPY hack/build-assets/certificate-transparency-go-1.1.6/certificate-transparency-go-1.1.6.tar.gz /ct_server/": checking on sources under "/workspace/source": copier: stat: "/hack/build-assets/certificate-transparency-go-1.1.6/certificate-transparency-go-1.1.6.tar.gz": no such file or directory

@JasonPowr
Copy link
Author

Ah changes are not in redhat-v0.6.5 yet thats why :) Ill run the script and update it

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit a223e54 into securesign:redhat-v0.6.5 Oct 18, 2023
11 of 12 checks passed
Gregory-Pereira pushed a commit to Gregory-Pereira/scaffolding that referenced this pull request Nov 20, 2023
* add unit test, update cloudsqlproxy pipeline

* update createcerts pipeline

* update createctconfig pipeline

* update createdb pipeline

* update createtree pipeline

* update ct-server

* update ctlog-managectroots pipeline

* update ctlog-verifyfulcio pipeline

* update tuf-server pipeline

* update dependency path for prefetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants