[SECURESIGN-171] Minimising amount of RHTAP builds. #112
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tommyd450 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@tommyd450: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tommyd450 I like what you are doing here. But I am confused with the results. It seems like this should have prevented the tuf-server-on-pull-request action from running, but it ran anyway. |
|
@lance this was my initial test but i switched to testing it on my fork as to not waste the main workspaces resources. And the current pathing is incorrect as it should be "cmd/tuf/server". I put this on the backburner for the moment as this is something tageted for tp2. Will be folloing up with lots of pr's for other repos. My only concern is that we technically wont trigger anybuilds unless one of those three things are changed so hopefully rhtap adds the ability to manually trigger a build on a custom pipeline. |
|
They are also running still as a change has been made to their individual tekton file which would also trigger a build. |
tommyd450
changed the title
| @@ -8,6 +8,7 @@ metadata: | |||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | |||
| pipelinesascode.tekton.dev/on-event: '[push]' | |||
| pipelinesascode.tekton.dev/on-target-branch: '[redhat-v0.6.5]' | |||
| pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "redhat-v0.6.5" && ( ".tekton/ct-server-push.yaml".pathChanged() || "/Dockerfile.ct-server".pathChanged() ) | |||
There was a problem hiding this comment.
I want to call brief attention to this line for any one reviewing.
There is no set of files present on this repo for ct_server.
So until rhtap implements triggering builds manually the only way to trigger a build for this would be to change either the dockerfile or tekton file.
There was a problem hiding this comment.
I think the Dockerfile.ct-server would qualify as a dependency, wouldn't it?
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using this pr to test the pipelinesascode.tekton.dev/on-cel-expression.