Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unit tests for rhtap #78

Conversation

JasonPowr
Copy link

Currently the way unit tests are running in RHTAP for rekor breaks the Red Hat contract this introduces changes to fix that

lance and others added 6 commits September 15, 2023 14:41
# Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content `/ok-to-test`

For more detailed information about running a PipelineRun, please refer
to Pipelines as Code documentation [Running the
PipelineRun](https://pipelinesascode.com/docs/guide/running/)

To customize the proposed PipelineRuns after merge, please refer to
[Build Pipeline
customization](https://redhat-appstudio.github.io/docs.appstudio.io/Documentation/main/how-to-guides/configuring-builds/proc_customize_build_pipeline/)

Co-authored-by: red-hat-trusted-app-pipeline <[email protected]>
This pr adds unit testing to rhtap for rekor. I've created my own
version of rekor in rhtap in my own workspace and have tested both fail
and success scenarios for both.

## Comments
I only went with that image as its the same used in the Docker files, if
it needs to be changed let me know 👍
Gonna work on the e2e tests next
This pr contains the necessary changes to the pipeline for the new
contract
Small pr to fix the hermetic builds in RHTAP, (mirrors the changes in
cosign)
@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonPowr
Once this PR has been reviewed and has the lgtm label, please assign cooktheryan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr
Copy link
Author

I've resolved the merge conflicts if that helps at all, the Dockerfiles are still out of date as the current changes are not present in midstream-v1.2.2

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

@JasonPowr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e f31331f link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lance lance force-pushed the redhat-v1.2.2 branch 2 times, most recently from 0bdc225 to ea42457 Compare October 3, 2023 20:15
@JasonPowr JasonPowr closed this Oct 4, 2023
@JasonPowr JasonPowr deleted the fix-for-unit-tests-in-pipeline branch October 27, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants