-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update unit tests for rhtap #78
update unit tests for rhtap #78
Conversation
# Pipelines as Code configuration proposal To start the PipelineRun, add a new comment with content `/ok-to-test` For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation [Running the PipelineRun](https://pipelinesascode.com/docs/guide/running/) To customize the proposed PipelineRuns after merge, please refer to [Build Pipeline customization](https://redhat-appstudio.github.io/docs.appstudio.io/Documentation/main/how-to-guides/configuring-builds/proc_customize_build_pipeline/) Co-authored-by: red-hat-trusted-app-pipeline <[email protected]>
This pr adds unit testing to rhtap for rekor. I've created my own version of rekor in rhtap in my own workspace and have tested both fail and success scenarios for both. ## Comments I only went with that image as its the same used in the Docker files, if it needs to be changed let me know 👍 Gonna work on the e2e tests next
This pr contains the necessary changes to the pipeline for the new contract
Small pr to fix the hermetic builds in RHTAP, (mirrors the changes in cosign)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JasonPowr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1da9990
to
e994491
Compare
I've resolved the merge conflicts if that helps at all, the Dockerfiles are still out of date as the current changes are not present in midstream-v1.2.2 |
@JasonPowr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
0bdc225
to
ea42457
Compare
Currently the way unit tests are running in RHTAP for rekor breaks the Red Hat contract this introduces changes to fix that