Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-unit-testing-to-rhtap #58

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

JasonPowr
Copy link

This pr adds unit testing to rhtap for rekor. I've created my own version of rekor in rhtap in my own workspace and have tested both fail and success scenarios for both.

Comments

I only went with that image as its the same used in the Docker files, if it needs to be changed let me know 👍
Gonna work on the e2e tests next

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonPowr
Once this PR has been reviewed and has the lgtm label, please assign cooktheryan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member

lance commented Sep 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2023
@lance lance merged commit fd57b18 into securesign:redhat-v1.2.2 Sep 22, 2023
9 of 10 checks passed
@JasonPowr JasonPowr deleted the add-unit-tests-to-rhtap branch September 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants