Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable hermetic builds and prefetched dependencies #169

Conversation

Gregory-Pereira
Copy link

@Gregory-Pereira Gregory-Pereira commented Nov 22, 2023

Also includes changes to get rekor back on a stable build in RHTAP

Copy link

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gregory-Pereira Gregory-Pereira changed the title enable hermetic builds enable hermetic builds and prefetched dependencies Nov 22, 2023
@lance
Copy link
Member

lance commented Nov 27, 2023

/retest

@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v1.3-enable-hermetic-builds-and-prefetched branch from 8d370dd to 9306b30 Compare November 28, 2023 04:02
@tommyd450
Copy link

@lance @Gregory-Pereira Are the hermetic working with go1.21 now?

@lance
Copy link
Member

lance commented Nov 28, 2023

@Gregory-Pereira you've got the git conflict indicators still in the yaml. Instead of this

<<<<<<< HEAD
  - name: build-source-image
    value: "true"
=======
  - name: hermetic
    value: "true"
  - name: prefetch-input
    value: '{"path": ".","type": "gomod"}'
>>>>>>> f52a2e7 (enable hermetic builds)

It should be this

  - name: build-source-image
    value: "true"
  - name: hermetic
    value: "true"
  - name: prefetch-input
    value: '{"path": ".","type": "gomod"}'

@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v1.3-enable-hermetic-builds-and-prefetched branch 8 times, most recently from 4804de3 to 5090836 Compare November 29, 2023 21:40
additionally adding prefetch-input but commenting it out due to pre-fetch dependencies go 1.21 dependency
@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v1.3-enable-hermetic-builds-and-prefetched branch from 5090836 to bc18fdb Compare November 30, 2023 03:37
@Gregory-Pereira Gregory-Pereira merged commit ecd43b3 into securesign:redhat-v1.3 Nov 30, 2023
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants