Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go version of base image to 1.21 #166

Conversation

Gregory-Pereira
Copy link

Similar to: securesign/scaffolding#132 but for rekor.

Fixes build issues based on go version in the base image.

/cc @lance

@openshift-ci openshift-ci bot requested a review from lance November 22, 2023 15:01
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance
Copy link
Member

lance commented Nov 22, 2023

/approve
/retest

Copy link

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira, lance, tommyd450

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member

lance commented Nov 22, 2023

/retest

@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v1.3-bump-go-base-image-1.21 branch from 741403a to 29c6701 Compare November 22, 2023 18:32
@openshift-ci openshift-ci bot removed the lgtm label Nov 22, 2023
Copy link

openshift-ci bot commented Nov 22, 2023

New changes are detected. LGTM label has been removed.

@lance
Copy link
Member

lance commented Nov 22, 2023

/retest

@Gregory-Pereira
Copy link
Author

Not sure why, but for some reason the contents of the src code directory is not getting coppied into the builder image

@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v1.3-bump-go-base-image-1.21 branch from 29c6701 to b199bf1 Compare November 23, 2023 18:46
@Gregory-Pereira Gregory-Pereira merged commit 9f77821 into securesign:redhat-v1.3 Nov 23, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants