-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get_public_logs #173
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 951351c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Can we rename PublicEvents to PublicLogs to gain consistency with the smart contract?
action: Record<string, any> | ||
} | ||
|
||
type PaginatedPublicEvent = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ParsedPagination<PublicEvent[]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the reason i did not use this name is becasue the name already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which name already exists?
} | ||
|
||
// Paginated response type for public events | ||
type GetPublicEventsResponse = PaginatedResponse<PublicEventResponse>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be <PublicEventResponse[]> correct?
const contractAddress = 'secret18537ttv4l4k2ea0xp6ay3sv4c243fyjtj2uqz7'; | ||
const lcdEndpoint = 'https://api.secret.com'; | ||
const chainId = 'secret-4'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just switch these to MOCK_VALUES so that it's clear we aren't actually querying real data via the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few more minors from me. Otherwise looks good!
pagination: contract.pageSize && contract.page | ||
? { page_size: contract.pageSize, page: contract.page } : undefined, | ||
}, | ||
}, | ||
})); | ||
|
||
return batchQuery$({ | ||
contractAddress: queryRouterContractAddress, | ||
codeHash: queryRouterCodeHash, | ||
contractAddress: queryPublicLogsContractAddress, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct, the batch query requires the query router.
Money market reward pools
* feat: more types * feat: start
No description provided.