Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning note and prepare v1.0.1 #67

Merged
merged 1 commit into from
May 13, 2024
Merged

Add versioning note and prepare v1.0.1 #67

merged 1 commit into from
May 13, 2024

Conversation

adityasaky
Copy link
Member

@adityasaky adityasaky requested a review from MarkLodato May 10, 2024 14:57
MarkLodato
MarkLodato approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to get a few more maintainers to approve, just to make sure we're all on the same page.

@adityasaky
Copy link
Member Author

Given we have three approvals and no comments expressing concerns, shall we merge and tag?

@MarkLodato
Copy link
Collaborator

SGTM

@adityasaky adityasaky merged commit fba27e4 into secure-systems-lab:master May 13, 2024
@adityasaky adityasaky deleted the prepare-v1.0.1 branch May 13, 2024 14:37
@adityasaky adityasaky mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

@lukpueh lukpueh lukpueh approved these changes

@MarkLodato MarkLodato MarkLodato approved these changes

@JustinCappos JustinCappos Awaiting requested review from JustinCappos

@SantiagoTorres SantiagoTorres Awaiting requested review from SantiagoTorres

@TomHennen TomHennen Awaiting requested review from TomHennen

@mnm678 mnm678 Awaiting requested review from mnm678

@joshuagl joshuagl Awaiting requested review from joshuagl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityasaky @MarkLodato @lukpueh @trishankatdatadog