Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unisat integration signPsbt functionality [ENG-5091] #48

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

victorkirov
Copy link
Member

Fixes a few issues with the unisat provider's signPsbt method:

  • the method now returns a base64 version of the signed PSBT
  • broadcasting now works

@victorkirov victorkirov requested a review from teebszet November 11, 2024 12:31
@victorkirov victorkirov self-assigned this Nov 11, 2024
teebszet
teebszet previously approved these changes Nov 12, 2024
m-aboelenein
m-aboelenein previously approved these changes Nov 12, 2024
@m-aboelenein m-aboelenein dismissed stale reviews from teebszet and themself via 26e1c66 November 12, 2024 10:40
@m-aboelenein m-aboelenein merged commit b6fc100 into main Nov 12, 2024
1 check passed
@m-aboelenein m-aboelenein deleted the fix/ENG-5091 branch November 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants