Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allowedSignHash from sign PSBT args + some fixes #43

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

victorkirov
Copy link
Member

  • allowedSignHash was removed as the implementation no longer requires it. It is also optional for Unisat, so there isn't a breaking change for the unisat integration.
  • lodash.omit was removed to decrease dependencies and was replaced with a basic, vanilla JS spread operator
  • a relative import was fixed
  • The Unisat adapter was brought up to date with the event listener function
  • The GitHub workflow was changed to run the build-debug script as the build script seems to ignore typing issues (like the missing Unisat method in pervious point)

@victorkirov victorkirov self-assigned this Oct 1, 2024
@m-aboelenein m-aboelenein merged commit 6f59d4a into main Oct 3, 2024
1 check passed
@m-aboelenein m-aboelenein deleted the victor/eng-5319-update-sats-connect-schema branch October 3, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants