Support for getBalance #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryzing
force-pushed
the
edu/misc-changes
branch
from
573add8 to
090c935
Compare
aryzing
force-pushed
the
edu/misc-changes
branch
from
090c935 to
c6e299d
Compare
…criptions added getInscriptions request
teebszet
reviewed
Jul 1, 2024
| @@ -7,7 +7,8 @@ import { MethodParamsAndResult, rpcRequestMessageSchema } from '../../types'; | |||
| import * as v from 'valibot'; | |||
|
|
|||
| export const getInfoMethodName = 'getInfo'; | |||
| export const getInfoParamsSchema = v.null(); | |||
| export const getInfoParamsSchema = v.nullish(v.null()); | |||
There was a problem hiding this comment.
For maximum compatibility, so devs can use either null or undefined when no params are needed. We should have come up with a better API that doesn't require the request(arg1, arg2) function to necessarily need a second argument.
teebszet
reviewed
Jul 1, 2024
| @@ -26,6 +26,8 @@ export interface RequestOptions<Payload extends RequestPayload, Response> { | |||
|
|
|||
| // RPC Request and Response types | |||
|
|
|||
| export const RpcIdSchema = v.optional(v.union([v.string(), v.number(), v.null()])); | |||
There was a problem hiding this comment.
curious: is this equivalent?
Suggested change
| export const RpcIdSchema = v.optional(v.union([v.string(), v.number(), v.null()])); | |
| export const RpcIdSchema = v.nullish(v.union([v.string(), v.number()])); |
There was a problem hiding this comment.
yes, recently learned about nullish, makes for more compact type defs
teebszet
approved these changes
Jul 1, 2024
teebszet
changed the base branch from
main
to
revert-22-revert-18-eduard/schema-validators
|
It shouldn't break existing apps. The changes are mostly additive. The wallet_connect/disconnect methods were never used / released / documented. I should have closed #18 as the work here superseded some of that work. |
aryzing
merged commit f9fbf35
into
revert-22-revert-18-eduard/schema-validators
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBalance.https://linear.app/xverseapp/issue/ENG-4527