Piano: Extremely Simple, Single-server PIR with Sublinear Server Computation #196
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
psi/piano/util.h
Outdated
| std::string Uint128ToBytes(uint128_t value); | ||
|
|
||
| // Generates a random 128-bit key using the provided RNG | ||
| PrfKey128 RandKey128(std::mt19937_64& rng); |
There was a problem hiding this comment.
使用yacl::crypto::Prg ，其余涉及到 rng 到地方也替换为同样的Prg.
psi/piano/util.h
Outdated
|
|
||
| namespace psi::piano { | ||
|
|
||
| constexpr size_t DBEntrySize = 8; // has to be a multiple of 8 |
There was a problem hiding this comment.
这里指的是数据库里一行数据的长度吗？单位是 bit 还是 字节？以及这里取8的出处是？
There was a problem hiding this comment.
单位是字节，原本使用vector<uint64_t>表示数据，所以取8，现在改为使用vector<uint8_t>，同时根据参数确定数据库里一行数据的字节数
psi/piano/util.h
Outdated
| constexpr size_t DBEntrySize = 8; // has to be a multiple of 8 | ||
| constexpr size_t DBEntryLength = DBEntrySize / 8; | ||
|
|
||
| using PrfKey128 = uint128_t; |
There was a problem hiding this comment.
引入这个头文件#include "yacl/base/int128.h" ，显式的使用yacl里提供的uint128_t 这个类型
psi/piano/util.h
Outdated
| PrfKey RandKey(std::mt19937_64& rng); | ||
|
|
||
| // Evaluates PRF using 128-bit key and returns a 64-bit result | ||
| uint64_t PRFEval128(const PrfKey128* key, uint64_t x); |
There was a problem hiding this comment.
对于 uint128_t 来说，可以直接pass by value ，不必使用pointer
psi/piano/util.h
Outdated
| constexpr size_t DBEntryLength = DBEntrySize / 8; | ||
|
|
||
| using PrfKey128 = uint128_t; | ||
| using DBEntry = std::array<uint64_t, DBEntryLength>; |
There was a problem hiding this comment.
看到了后面大量的关于DBEntry 相关的操作。是否可以考虑，将DBEntry 进一步抽象为一个class 或者 struct？
psi/piano/util.h
Outdated
| using DBEntry = std::array<uint64_t, DBEntryLength>; | ||
| using PrfKey = PrfKey128; | ||
|
|
||
| uint128_t BytesToUint128(const std::string& bytes); |
There was a problem hiding this comment.
使用 yacl中ByteContainerView，或者std::vector<uint8_t> 来表示 bytes，而不是std::string
psi/piano/client.h
Outdated
|
|
||
| class QueryServiceClient { | ||
| public: | ||
| static constexpr uint64_t FailureProbLog2 = 40; |
psi/piano/client.h
Outdated
| class QueryServiceClient { | ||
| public: | ||
| static constexpr uint64_t FailureProbLog2 = 40; | ||
| uint64_t totalQueryNum{}; |
psi/piano/client.h
Outdated
|
|
||
| std::vector<LocalSet> primary_sets_; | ||
| std::vector<LocalBackupSet> local_backup_sets_; | ||
| std::map<uint64_t, DBEntry> local_cache_; |
There was a problem hiding this comment.
如果不要求有序，使用std::unordered_map 即可
psi/piano/util.h
Outdated
|
|
||
| class PRSetWithShortTag { | ||
| public: | ||
| uint32_t Tag; |
There was a problem hiding this comment.
放在 private 下，或者用 struct 即可
psi/piano/util.cc
Outdated
| return entry; | ||
| } | ||
|
|
||
| uint64_t DefaultHash(uint64_t key) { |
There was a problem hiding this comment.
这里只是为了生成测试数据，所以使用了简单高效的FNV哈希，已转移到测试代码中实现，逻辑和参数选取参考自https://en.wikipedia.org/wiki/Fowler%E2%80%93Noll%E2%80%93Vo_hash_function
Piano: Extremely Simple, Single-server PIR with Sublinear Server Computation