Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try increasing BatchHypevolumeSharpeRatioIndicator num_steps #798

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Try increasing BatchHypevolumeSharpeRatioIndicator num_steps #798

merged 1 commit into from
Dec 5, 2023

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented Dec 5, 2023 •
edited
Loading

Related issue(s)/PRs:

Summary

Recent unrelated changes have broken one of the integration tests due to RNG. Increasing the maximum number of iterations appears to fix it.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta marked this pull request as ready for review December 5, 2023 14:41
@uri-granta uri-granta merged commit c537c5b into develop Dec 5, 2023
15 checks passed
@uri-granta uri-granta deleted the uri/quickfix/slow_tests branch December 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khurram-ghani khurram-ghani khurram-ghani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @khurram-ghani