Make ProbabilisticModel a pure interface #797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs:
Summary
Tidy up ProbabilisticModel and TrainableProbabilisticModel so that they are pure interfaces. Includes making
SupportsPredictY
a separate protocol, which improves static type checking.Fully backwards compatible: no
A few breaking changes justified by simplifying the core type hierarchy. Migration is straightforward and will be properly documented.
ProbabilisticModel.log
is now an abstract method and needs to be explicitly specified in any concrete model class implementationProbabilisticModel.get_module_with_variables
is now a utility function intrieste.models.utils
TrainableProbabilisticModel.optimize_and_save_result
andTrainableProbabilisticModel.last_optimization_result
are now also utility functions (renamed tooptimize_model_and_save_result
andget_last_optimization_result
)PR checklist