Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IndependentReparametrizationSampler create variables at init #789

Closed
wants to merge 2 commits into from
Closed

Make IndependentReparametrizationSampler create variables at init #789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96348ff
change sampler
sam-willis Oct 11, 2023
54b5c58
formatting
sam-willis Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions trieste/models/gpflow/sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,11 @@ def __init__(
:raise ValueError (or InvalidArgumentError): If ``sample_size`` is not positive.
"""
super().__init__(sample_size, model)
self._eps: Optional[tf.Variable] = None
self._eps = tf.Variable(
tf.zeros(shape=(sample_size, 0), dtype=tf.float64),
shape=(sample_size, None),
dtype=tf.float64,
)
self._qmc = qmc
self._qmc_skip = qmc_skip

Expand Down Expand Up @@ -141,9 +145,6 @@ def sample_eps() -> tf.Tensor:
)
return normal_samples # [S, L]

if self._eps is None:
self._eps = tf.Variable(sample_eps())

tf.cond(
self._initialized,
lambda: self._eps,
Expand Down
Loading