Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFF for simple additive kernels #104

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

khurram-ghani
Copy link
Collaborator

@khurram-ghani khurram-ghani commented Sep 19, 2024

Add RFF support for additive kernels. Re-using the existing multi-output structure as much as possible, and generalising it.

This adds RFF for simple additive kernels only. So kernels can now be Matern/RBF or multi-output or Sum. It doesn't support mixing muti-output with combination kernels for instance; that would get complex if we start considering cases where only some of the latent-kernels are a combination etc.

In the combination (i.e. Sum) kernel case, the number of feature is multiplied by the number of sub-kernels. I tried to keep them as a separate dimension (first one), as in the multi-output case, but that doesn't work well with trieste/gpflow. The main reason being that normal kernels and multi-output kernels behave slightly differently in gpflow, and adding an extra dimension to the covariance matrix causes issues in the normal kernel case. So for this gpflux PR, the dimension is kept separate in most places, but when the features are returned in call, it is flattened into the last (features) dimension.

The generalisation of the batching may be useful for any future combination kernels and batching functionality we add support for.

@khurram-ghani khurram-ghani changed the title Add RFF for additive kernel Add RFF for additive kernels Sep 19, 2024
@khurram-ghani khurram-ghani changed the title Add RFF for additive kernels Add RFF for simple additive kernels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant