Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large update to the repo. As most test files have changed I provide an overview here.
Changes in neural network tests
The neural networks tests (net tests) are still the same. The difference is that the input, parameters and output are now provided in HDF5 file format. The saved arrays are in row-major, following PyTorch indexing. I have tested and confirmed consistent results between Julia and PyTorch.
Changes in hybrid tests
I have now updated the yaml file to version 2. Basically, now the file looks like:
As discussed each network now has its own parameter file, e.g.
net1_ps.h5
. Additionally, I have:Note that settings for neural networks (such as whether to estimate the parameters or not) can be specified in the parameters table. The only thing left is the point regarding condition table in #4, but I will open a separate issue on this.
I have run all the test-cases through PEtab.jl.
@FFroehlich and @dilpath if this looks good I will merge this, close #4, and open a new issue with the points that are left to address.