This repository has been archived by the owner on Sep 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jameshadfield, @jotasolano ---
I believe the choropleths were not presenting the core thing they needed to present, that is the count of encounters in a region. Incidence is the primary data variable we want to display. Sex, age, vaccination, etc... are secondary colorings. There is no easy way in the existing app framework to display a very simple thing:
The map always displays the "secondary" data variable (vaccination, etc...).
This PR addresses this by swapping the choropleth for a circle sized according to absolute total count from this region. There is certainly more to do here in terms of piecharts vs circles and color embeddings, but I believe this is separable from choropleth vs circle.
Here are two examples of changes in app behavior:
Neighborhood / vaccination via choropleth:
Neighborhood / vaccination via circle:
Census tract / sex via choropleth:
Census tract / sex via circle:
You can especially see in the census tract version that many of choropleth colorings are based on a single data point and are overly emphasized. By having these just be tiny circles these census tracts are properly deemphasized. I can see meaning in the latter, but not in the former.