Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutocompleteController Bind settings #1220

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

korgon
Copy link
Contributor

@korgon korgon commented Dec 5, 2024

Adding ability to opt out of either input or submit bindings in AutocompleteController via controller settings.

Example:

autocomplete: [
	{
		config: {
			id: 'autocomplete',
			selector: 'input.searchspring-ac',
			settings: {
				bind: {
					input: false
					submit: false
				}
			},
		},
	},
],

I've combined the input enter key press and form submit events into one "submit" so simplify configuration. Additionally, there are other bindings that occur for things like document click, input focus and input escape key press that I don't think are necessary to provide settings for, but could be added if we needed to.

dkonieczek
dkonieczek previously approved these changes Dec 5, 2024
@korgon korgon merged commit a9d884e into develop Dec 9, 2024
1 check passed
@korgon korgon deleted the autocomplete-bind-settings branch December 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants