Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(urltranslator.ts): gracefully catch malformed uri errors #1217

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix(urltranslator.ts): gracefully catch malformed uri errors #1217

merged 3 commits into from
Dec 9, 2024

Conversation

chrisFrazier77
Copy link
Contributor

No description provided.

@chrisFrazier77 chrisFrazier77 linked an issue Dec 4, 2024 that may be closed by this pull request
Decoding Malformed URLs #1215
Closed
korgon
korgon requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some testing should be added around this. Also, is this a problem for hash parameters that we would need to also address?

packages/snap-url-manager/src/Translators/Url/UrlTranslator.ts Outdated Show resolved Hide resolved
packages/snap-url-manager/src/Translators/Url/UrlTranslator.ts Outdated Show resolved Hide resolved
korgon
korgon requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems a bit off about the new test assertion in the hash.

packages/snap-url-manager/src/Translators/Url/UrlTranslator.test.ts Outdated Show resolved Hide resolved
@korgon korgon merged commit 0edb1ae into develop Dec 9, 2024
1 check passed
@korgon korgon deleted the decodeurl-bugfix branch December 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoding Malformed URLs
2 participants
@chrisFrazier77 @korgon