Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendation Back/Forward Cache #1208

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Recommendation Back/Forward Cache #1208

merged 3 commits into from
Dec 4, 2024

Conversation

chrisFrazier77
Copy link
Contributor

No description provided.

@chrisFrazier77 chrisFrazier77 linked an issue Nov 18, 2024 that may be closed by this pull request
Recommendation Back/Forward Cache #1195
Closed
korgon
korgon requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look to cover the controller creation use case. Have you tested the case when using the instantiator?

packages/snap-store-mobx/src/types.ts Outdated Show resolved Hide resolved
@korgon korgon merged commit 2099968 into develop Dec 4, 2024
1 check passed
@korgon korgon deleted the backforwardcache branch December 4, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommendation Back/Forward Cache
2 participants
@chrisFrazier77 @korgon