fix(recommendationcontroller): send core result data and not active d…

…isplay data in beacon tracking
searchspring · Nov 12, 2024 · 1c1754a · 1c1754a
1 parent 13e39b7
commit 1c1754a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/snap-controller/src/Recommendation/RecommendationController.test.ts b/packages/snap-controller/src/Recommendation/RecommendationController.test.ts
@@ -541,6 +541,10 @@ describe('Recommendation Controller', () => {
 		 */
 
 		const result = controller.store.results[0];
+
+		//this tests we send the core data and not the display data
+		result.mask.set({ id: 'custom' });
+
 		const productEventReturn = controller.track.product.impression(result);
 
 		expect(trackfn).toHaveBeenCalledWith({

diff --git a/packages/snap-controller/src/Recommendation/RecommendationController.ts b/packages/snap-controller/src/Recommendation/RecommendationController.ts
@@ -142,7 +142,7 @@ export class RecommendationController extends AbstractController {
 							product: {
 								id: result.id,
 								mappings: {
-									core: result.display.mappings.core,
+									core: result.mappings.core,
 								},
 								seed: getSeed(),
 							},
@@ -170,7 +170,7 @@ export class RecommendationController extends AbstractController {
 							product: {
 								id: result.id,
 								mappings: {
-									core: result.display.mappings.core,
+									core: result.mappings.core,
 								},
 								seed: getSeed(),
 							},
@@ -198,7 +198,7 @@ export class RecommendationController extends AbstractController {
 							product: {
 								id: result.id,
 								mappings: {
-									core: result.display.mappings.core,
+									core: result.mappings.core,
 								},
 								seed: getSeed(),
 							},
@@ -233,7 +233,7 @@ export class RecommendationController extends AbstractController {
 							product: {
 								id: result.id,
 								mappings: {
-									core: result.display.mappings.core,
+									core: result.mappings.core,
 								},
 								seed: getSeed(),
 							},
@@ -268,7 +268,7 @@ export class RecommendationController extends AbstractController {
 							product: {
 								id: result.id,
 								mappings: {
-									core: result.display.mappings.core,
+									core: result.mappings.core,
 								},
 								seed: getSeed(),
 							},
@@ -297,7 +297,7 @@ export class RecommendationController extends AbstractController {
 						products: results.map((result) => ({
 							id: result.id,
 							mappings: {
-								core: result.display.mappings.core,
+								core: result.mappings.core,
 							},
 							quantity: result.quantity,
 						})),