Skip to content

Commit

Permalink
Merge pull request #72 from searchspring/php-compatibility
Browse files Browse the repository at this point in the history
PHP Compatibility
  • Loading branch information
maheshganjalagunte authored Sep 8, 2023
2 parents 9c74e0c + f70c1cc commit c3a049a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion Helper/Generator.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ class Generator extends \Magento\Framework\App\Helper\AbstractHelper
protected $layoutInterface;
protected $galleryReadHandler;

protected $productRepository;
protected $ratingFactory;
protected $eavConfig;
protected $viewConfig;
protected $productEntityTypeId;

protected $storeManager;

protected $storeId;
Expand Down Expand Up @@ -894,7 +900,7 @@ protected function writeCsvRecord($productRecord)

$output = [];
foreach ($row as $field) {
$output[] = preg_match("/(?:${delimiter_esc}|${enclosure_esc}|\s)/", $field) ? (
$output[] = preg_match("/(?:{$delimiter_esc}|{$enclosure_esc}|\s)/", $field) ? (
$enclosure . str_replace($enclosure, $enclosure . $enclosure, $field) . $enclosure
) : $field;
}
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" ?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="SearchSpring_Feed" setup_version="1.2.1"/>
<module name="SearchSpring_Feed" setup_version="1.2.2"/>
</config>

0 comments on commit c3a049a

Please sign in to comment.