Add tests for SMC Capability #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furao
force-pushed
the
smc_cap
branch
2 times, most recently
from
bba5238 to
f631146
Compare
Indanz
reviewed
Aug 14, 2023
Merged
kent-mcleod
reviewed
Aug 29, 2023
|
|
||
| return sel4test_get_result(); | ||
| } | ||
| DEFINE_TEST(SMC0001, "Test SMC calls", test_smc_calls, true) |
There was a problem hiding this comment.
Is it reasonable to assume that CONFIG_ALLOW_SMC_CALLS will only be enabled on sel4test runs when the test platform also has a compatible ATF running for this test to pass?
There was a problem hiding this comment.
(It seems reasonable to me)
There was a problem hiding this comment.
I think so too. You really need to go looking to add it in.
There was a problem hiding this comment.
I thought ARM mandates ATF for Aarch64, or at least strongly encourages it.
kent-mcleod
approved these changes
Aug 29, 2023
Signed-off-by: Robbie VanVossen <[email protected]>
|
CI should probably be updated to include another test configuration on at least the zcu106 to enable |
Indanz
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new test will make sure that the SMC capability and its associated API call work as expected.
It tests the following:
I tested this with the following configuration:
I wanted to test on QEMU, but it turned out to be non-trivial to integrate ATF with QEMU for sel4Test. It is doable, but I don't have the bandwidth to support it.
Note: This test assumes you are running ATF in EL3 on an AARCH64 platform. The successful test checks the standard service version and it reports back 0.1 (See https://github.com/ARM-software/arm-trusted-firmware/blob/master/include/services/std_svc.h). Technically this could change in the future and break the test, however the version hasn't changed in the last 9 years since the service was written.
This test requires these PRs: