Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove explicit newline in ZF_LOGx() #122

Merged
merged 3 commits into from
Jun 17, 2024
Merged

remove explicit newline in ZF_LOGx() #122

merged 3 commits into from
Jun 17, 2024

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented May 28, 2024

  • remove explicit newline in ZF_LOGx(), the functions already prints a newline at the end.
  • SCHED0003: log debug information instead of empty lines

lsf37
lsf37 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. I've been wondering why we are adding all those empty lines. Did the ZF_LOGV implementation change at some point?

@axel-h
Copy link
Member Author

axel-h commented May 29, 2024

Some might have been printf() once. Or just sloppyness.

Axel Heider added 2 commits June 12, 2024 21:49
SCHED0003: log debug information
5e70ca9 
Signed-off-by: Axel Heider <[email protected]>
remove explicit newline in ZF_LOGx()
d8b6e6b 
The functions already prints a newline at the end.

Signed-off-by: Axel Heider <[email protected]>
@lsf37 lsf37 self-assigned this Jun 16, 2024
@lsf37 lsf37 merged commit 2587dda into seL4:master Jun 17, 2024
20 checks passed
@axel-h axel-h deleted the patch-axel-7 branch July 2, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsf37 lsf37 lsf37 approved these changes

Assignees

@lsf37 lsf37

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axel-h @lsf37