Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Pine64 Star64 #174

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add support for Pine64 Star64 #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmake-tool/helpers/application_settings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ include_guard(GLOBAL)
function(ApplyData61ElfLoaderSettings kernel_platform kernel_sel4_arch)
set(
binary_list
"tx1;hikey;odroidc2;odroidc4;imx8mq-evk;imx8mm-evk;hifive;tqma8xqp1gb;bcm2711;rocketchip"
"tx1;hikey;odroidc2;odroidc4;imx8mq-evk;imx8mm-evk;hifive;tqma8xqp1gb;bcm2711;rocketchip;star64"
)
set(efi_list "tk1;rockpro64;quartz64")
set(uimage_list "tx2;am335x")
Expand Down Expand Up @@ -59,6 +59,9 @@ function(ApplyData61ElfLoaderSettings kernel_platform kernel_sel4_arch)
endif()
set(IMAGE_START_ADDR 0x10000000 CACHE INTERNAL "" FORCE)
endif()
if(KernelPlatformStar64)
set(IMAGE_START_ADDR 0x60000000 CACHE INTERNAL "" FORCE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment where this address comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what I would say because it comes from the same place as all the other addresses in that file - somewhere in RAM that doesn't overlap with anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, could say this for the whole section then, that it's an arbitrary choice unless stated otherwise. That answer feels lika a deja-vu somehow.

endif()
endfunction()

function(ApplyCommonSimulationSettings kernel_sel4_arch)
Expand Down