-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wildcard parameterized type #121
Conversation
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
v1@yhtMinceraft1010X submitted v1 for review.
Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/121/1/head:BRANCHNAME where |
Thanks very much for the PR @yhtMinceraft1010X |
That seems to remove that warning. This change seems fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks all for the reviews. @yhtMinceraft1010X perhaps we can omit Intellij from the commit message? Rationale: as this a improvement to the code, we should be able to justify it without relying on an IDE warning. |
Thanks Prof! I have fixed the commit message |
IntelliJ throws a warning that assertParseSuccess and assertParseFailure parameter parser uses raw type for Parser. This warning is similar to javac -Xlint:rawtypes. Let's add a wildcard type parameter to Parser.
v2@yhtMinceraft1010X submitted v2 for review.
(📚 Archive) (📈 Interdiff between v1 and v2) (📈 Range-Diff between v1 and v2) Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/121/2/head:BRANCHNAME where |
Thanks for the fix @yhtMinceraft1010X |
Part of #122
Proposed commit message: