Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clippy errors and small typos in write function #36

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Jul 15, 2024

Proposed Changes

  • Make all clippy warnings errors.
  • Correct write functions.

Types of Changes

What types of changes does your code introduce? Put an x in the boxes that
apply

  • A bug fix (non-breaking change which fixes an issue).
  • A new feature (non-breaking change which adds functionality).
  • A breaking change (fix or feature that would cause existing
    functionality to not work as expected).
  • A non-productive update (documentation, tooling, etc. if none of the
    other choices apply).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read the
    CONTRIBUTING
    guidelines.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation (if appropriate).

Further Comments

@gabyx gabyx force-pushed the feat/small-improvements branch from c23de87 to 35f396e Compare July 15, 2024 13:10
@cmdoret cmdoret self-requested a review July 15, 2024 13:11
@cmdoret cmdoret added the enhancement New feature or request label Jul 15, 2024
@@ -35,7 +35,7 @@ struct IndexArgs {

/// File descriptor to read triples from.
/// Defaults to `stdin`.
#[arg(default_value = "-")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is there any issues with having input as positional argument? i.e.

index data.nt
instead of
index -i input.nt

Also this would set -i as the short option, which kind of clashes with index in pseudo -i

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah jeah. that might be better. Make --input and --index. I am anyway not a big fan of using abreviations.
or -i and -x for index. @cmdoret : can you do a PR on this?

@cmdoret cmdoret merged commit fddccd5 into main Jul 16, 2024
7 checks passed
@cmdoret cmdoret deleted the feat/small-improvements branch July 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants