support patterns from string descriptors #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Great work with this fork!
To my surprise, 42Crunch recently indicated to me that some uuid/guid schemas were not setting patterns in the openapi schema. Have you ever considered something like my proposed change? The
string().uuid().regex(/not-at-all-uuid-compatible/)
possibility does bother me a little.Please let me know what you think. Thanks for all your work on this.
Edit: Also curious if you've had any contact with the original author. It would be great to have a place to create issues etc.