fix error when set data in safari #948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
在IOS 10.3.1的Safari里面，尝试对原生DOM对象的dataset做delete操作，会报`TypeError: Unable to delete property.` 仔细看了方法`$.fn.data`，在读取data的时候，优先取的__eleData，而写入的时候也会写入__eleData。所以`if (key in tmpData) delete el.dataset[key];`是多余的，而且tmpData里面有，不等于el.dataset[key]就一定有值的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在IOS 10.3.1的Safari里面，尝试对原生DOM对象的dataset做delete操作，会报
TypeError: Unable to delete property.。在StackOverflow上面也有类似的问题http://stackoverflow.com/questions/28973603/unable-to-delete-property-on-safari-when-trying-to-delete-dataset-attribute-in仔细看了方法
$.fn.data，在读取data的时候，优先取的__eleData，而写入的时候也会写入__eleData。所以if (key in tmpData) delete el.dataset[key];是多余的，而且tmpData里面有，不等于el.dataset[key]就一定有值的。