New license banner and search style #1316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgarcia360 updated |
|
@kwiato In Figma it looks a bit different: 
I like the white text over the dark text, but I'm not sure if the link has enough contrast with the background in blue. What are your thoughts? On a separate note, I'll submit some edits to make the banner an RST directive to avoid hardcoding HTML in the RST page and to conditionally load the banner before the heading in documentation pages. |
|
Added some edits:
|
dgarcia360
reviewed
Dec 24, 2024
dgarcia360
force-pushed
the
license-banner
branch
from
3dda718 to
845eb73
Compare
|
Status: we've agreed to merge this PR and revisit the banner later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.