Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seastar submodule #22076

Closed
wants to merge 1 commit into from
Closed

Update seastar submodule #22076

wants to merge 1 commit into from

Conversation

bhalevy
Copy link
Member

@bhalevy bhalevy commented Dec 30, 2024

  • seastar 3133ecdd...a9bef537 (24):

    file: add file_system_space
    future: avoid inheriting from future payload type
    treewide: include fmt/ostream.h for using fmt::print()
    build: remove messages used for debugging
    demos: Rename websocket demo to websocket_server demo
    demos: Add a way to set port from cmd line in websocket demo
    tls: Add optional builder + future-wait to cert reload callback + expose rebuild
    rwlock: add try_hold_{read,write}_lock methods
    json: add moving push to json_list
    github: add a step to build "check-include-style"
    build: add a target for checking include style
    scheduling_group: use map for key configs instead of vector
    scheduling_group: fix indentation
    scheduling_group: fix race between scheduling group and key creation
    http: Make request writing functions public
    http: Expose connection_factory implementations
    metrics: Use separate type for shared metadata
    file: unexpected throw from inside noexcept
    metrics: Internalize metric label sets
    thread: optimize maybe_yield
    reactor: fix crash in pending registration task after poller dtor
    net: Fix ipv6 socket_address comparision
    reactor, linux-aio: factor out get_smp_count() lambda
    reactor, linux-aio: restore "available_aio" meaning after "reserve_iocbs"

Fixed usage of seastar metric label sets due to:
scylladb/seastar@733420d57 Merge 'metrics: Internalize metric label sets' from Stephan Dollberg

  • Update of seastar submodule, no backport required.

@bhalevy
Update seastar submodule
64f9c72 
* seastar 3133ecdd...a9bef537 (24):
  > file: add file_system_space
  > future: avoid inheriting from future payload type
  > treewide: include fmt/ostream.h for using fmt::print()
  > build: remove messages used for debugging
  > demos: Rename websocket demo to websocket_server demo
  > demos: Add a way to set port from cmd line in websocket demo
  > tls: Add optional builder + future-wait to cert reload callback + expose rebuild
  > rwlock: add try_hold_{read,write}_lock methods
  > json: add moving push to json_list
  > github: add a step to build "check-include-style"
  > build: add a target for checking include style
  > scheduling_group: use map for key configs instead of vector
  > scheduling_group: fix indentation
  > scheduling_group: fix race between scheduling group and key creation
  > http: Make request writing functions public
  > http: Expose connection_factory implementations
  > metrics: Use separate type for shared metadata
  > file: unexpected throw from inside noexcept
  > metrics: Internalize metric label sets
  > thread: optimize maybe_yield
  > reactor: fix crash in pending registration task after poller dtor
  > net: Fix ipv6 socket_address comparision
  > reactor, linux-aio: factor out get_smp_count() lambda
  > reactor, linux-aio: restore "available_aio" meaning after "reserve_iocbs"

Fixed usage of seastar metric label sets due to:
scylladb/seastar@733420d57 Merge 'metrics: Internalize metric label sets' from Stephan Dollberg
@bhalevy bhalevy added the backport/none Backport is not required label Dec 30, 2024
@bhalevy bhalevy requested a review from avikivity December 30, 2024 08:49
This was referenced Dec 30, 2024
Closed
Draft
@bhalevy bhalevy requested a review from amnonh December 30, 2024 10:43
@bhalevy
Copy link
Member Author

bhalevy commented Dec 30, 2024

@amnonh please review metrics-related changes

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test
✅ - Docker Test
✅ - dtest
✅ - dtest with tablets
✅ - dtest with topology changes
✅ - Offline-installer Artifact Tests
❌ - Unit Tests

Failed Tests (1/36526):

Build Details:

  • Duration: 8 hr 49 min
  • Builder: i-04c3a33d210ebea0a (m5ad.8xlarge)

@tchaikov
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build ✅ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/group0_test 🔹 boost/query_processor_test ✅ - Docker Test ✅ - dtest ✅ - dtest with tablets ✅ - dtest with topology changes ✅ - Offline-installer Artifact Tests ❌ - Unit Tests

Failed Tests (1/36526):

* [test_random_failures[stop_after_updating_cdc_generation-restart_coordinator_node].debug.2](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/14127/testReport/junit/topology_random_failures/test_random_failures/Tests___Unit_Tests___test_random_failures_stop_after_updating_cdc_generation_restart_coordinator_node__debug_2) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+test_random_failures%5Bstop_after_updating_cdc_generation-restart_coordinator_node%5D.debug.2)

#21872

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
❌ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test

Build Details:

  • Duration: 44 min
  • Builder: spider4.cloudius-systems.com

@bhalevy
Copy link
Member Author

bhalevy commented Dec 31, 2024

🔴 CI State: FAILURE

✅ - Build ❌ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/group0_test 🔹 boost/query_processor_test

Build Details:

  • Duration: 44 min
  • Builder: spider4.cloudius-systems.com
09:07:12  Error: test failed, error: |hudson.AbortException: script returned exit code 1|.

Looks like spot termination

@tchaikov
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build ❌ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/group0_test 🔹 boost/query_processor_test

Build Details:

  • Duration: 44 min
  • Builder: spider4.cloudius-systems.com
09:07:12  Error: test failed, error: |hudson.AbortException: script returned exit code 1|.

Looks like spot termination

i don't think so. see

15:07:10  + bash -c 'set -o pipefail; ./tools/toolchain/dbuild -e ENABLE_KMS_TEST=1 -e ENABLE_GCP_TEST=1 -e AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY -e AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID -e GCP_USER_1_CREDENTIALS=$GCP_USER_1_CREDENTIALS -v $GCP_USER_1_CREDENTIALS:$GCP_USER_1_CREDENTIALS -e GCP_USER_2_CREDENTIALS=$GCP_USER_2_CREDENTIALS -v $GCP_USER_2_CREDENTIALS:$GCP_USER_2_CREDENTIALS -v `pwd`:/scylladir -v /jenkins/coredumps:/jenkins/coredumps -- ./test.py  --tmpdir=/scylladir/testlog/x86_64 --artifacts_dir_url https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/14140/artifact --verbose --repeat 10 "boost/group0_test::*" "boost/query_processor_test::*" --no-gather-metrics 2>&1 | tee tests_console_output_x86_64.txt'
15:07:11  Test boost/group0_test::* not found

somehow, none of the tests under boost/group0_test was found.

@tchaikov
Copy link
Contributor

created #22086

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
❌ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test

Build Details:

  • Duration: 45 min
  • Builder: spider5.cloudius-systems.com

@tchaikov
Copy link
Contributor

tchaikov commented Jan 2, 2025 •
edited
Loading

🔴 CI State: FAILURE

✅ - Build ❌ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/group0_test 🔹 boost/query_processor_test

Build Details:

* Duration: 45 min

#22086

@bhalevy
Copy link
Member Author

bhalevy commented Jan 2, 2025

🔴 CI State: FAILURE

✅ - Build ❌ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/group0_test 🔹 boost/query_processor_test

Build Details:

* Duration: 45 min

#22086

Thanks @tchaikov!
Do you have any idea on how to work around this, or do we need to wait for a fix?

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
❌ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test

Build Details:

  • Duration: 10 hr
  • Builder: spider8.cloudius-systems.com

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
❌ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test

Build Details:

  • Duration: 46 min
  • Builder: spider2.cloudius-systems.com

@tchaikov
Copy link
Contributor

tchaikov commented Jan 6, 2025

this change is pending on #22163

@bhalevy
Copy link
Member Author

bhalevy commented Jan 6, 2025

this change is pending on #22163

CI respinned now that #22163 is fixed.

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test
✅ - Docker Test
✅ - Offline-installer Artifact Tests
❌ - Unit Tests

Build Details:

  • Duration: 9 hr 1 min
  • Builder: i-0944116bb405fb815 (m5ad.8xlarge)

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test
✅ - Offline-installer Artifact Tests
✅ - Docker Test
❌ - Unit Tests

Failed Tests (1/29738):

Build Details:

  • Duration: 9 hr 8 min
  • Builder: i-05abd296febea0781 (m5ad.8xlarge)

@tchaikov
Copy link
Contributor

tchaikov commented Jan 8, 2025

🔴 CI State: FAILURE

✅ - Build ✅ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/group0_test 🔹 boost/query_processor_test ✅ - Offline-installer Artifact Tests ✅ - Docker Test ❌ - Unit Tests

Failed Tests (1/29738):

* [test_auth_v2_during_recovery.debug.3](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/14250/testReport/junit/auth_cluster/test_auth_v2_migration/test_auth_v2_during_recovery_debug_3) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+test_auth_v2_during_recovery.debug.3)

looks like #21093

@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/group0_test
🔹 boost/query_processor_test
✅ - Offline-installer Artifact Tests
✅ - Docker Test
✅ - Unit Tests

Build Details:

  • Duration: 4 hr 49 min
  • Builder: spider1.cloudius-systems.com

@bhalevy bhalevy added the status/merge candidate Item needs maintainer attention label Jan 8, 2025
@bhalevy
Copy link
Member Author

bhalevy commented Jan 8, 2025

@scylladb/scylla-maint please consider merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avikivity avikivity avikivity approved these changes

@amnonh amnonh Awaiting requested review from amnonh

Assignees
No one assigned
Labels
backport/none Backport is not required promoted-to-master status/merge candidate Item needs maintainer attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhalevy @scylladb-promoter @tchaikov @avikivity @scylladbbot