Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unified naming for statements #993

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

muzarski
Copy link
Contributor

@muzarski muzarski commented May 6, 2024

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@muzarski muzarski marked this pull request as draft May 6, 2024 21:12
@muzarski muzarski force-pushed the rename_simple_query_to_unprepared_statement branch from 1083be2 to e1486f3 Compare May 6, 2024 21:14
@muzarski muzarski added the API-breaking This might introduce incompatible API changes label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

cargo semver-checks detected some API incompatibilities in this PR.
Checked commit: 43703b7

See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 88bc8c18c69f321137929dab151dc13c94dd1560
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 88bc8c18c69f321137929dab151dc13c94dd1560
     Cloning 88bc8c18c69f321137929dab151dc13c94dd1560
     Parsing scylla v0.13.0 (current)
      Parsed [  19.807s] (current)
     Parsing scylla v0.13.0 (baseline)
      Parsed [  18.443s] (baseline)
    Checking scylla v0.13.0 -> v0.13.0 (no change)
     Checked [   0.508s] 72 checks; 70 passed, 2 failed, 0 unnecessary

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/module_missing.ron

Failed in:
  mod scylla::statement::query, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-88bc8c18c69f321137929dab151dc13c94dd1560/0c26f914767b7fed84ea4e2ae0ed287f3e2b4289/scylla/src/statement/query.rs:1
  mod scylla::query, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-88bc8c18c69f321137929dab151dc13c94dd1560/0c26f914767b7fed84ea4e2ae0ed287f3e2b4289/scylla/src/statement/query.rs:1

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/struct_missing.ron

Failed in:
  struct scylla::statement::query::Query, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-88bc8c18c69f321137929dab151dc13c94dd1560/0c26f914767b7fed84ea4e2ae0ed287f3e2b4289/scylla/src/statement/query.rs:13
  struct scylla::query::Query, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-88bc8c18c69f321137929dab151dc13c94dd1560/0c26f914767b7fed84ea4e2ae0ed287f3e2b4289/scylla/src/statement/query.rs:13
     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [  38.806s] scylla
     Parsing scylla-cql v0.2.0 (current)
      Parsed [  10.088s] (current)
     Parsing scylla-cql v0.2.0 (baseline)
      Parsed [  10.221s] (baseline)
    Checking scylla-cql v0.2.0 -> v0.2.0 (no change)
     Checked [   0.258s] 72 checks; 72 passed, 0 unnecessary
    Finished [  20.609s] scylla-cql
make: *** [Makefile:61: semver-rev] Error 1

@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label May 6, 2024
@muzarski muzarski self-assigned this May 8, 2024
@muzarski muzarski force-pushed the rename_simple_query_to_unprepared_statement branch from e1486f3 to fd184dd Compare May 15, 2024 13:04
@muzarski muzarski force-pushed the rename_simple_query_to_unprepared_statement branch from fd184dd to 43703b7 Compare May 15, 2024 13:11
@roydahan roydahan requested a review from wprzytula June 3, 2024 11:51
@wprzytula wprzytula removed their request for review June 4, 2024 05:03
@wprzytula
Copy link
Collaborator

@roydahan this is a WIP, I don't think I should review it yet.

@wprzytula wprzytula added this to the 0.17.0 milestone Aug 20, 2024
@Lorak-mmk Lorak-mmk modified the milestones: 0.17.0, 0.16.0 Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-breaking This might introduce incompatible API changes semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants