-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Unified naming for statements #993
Draft
muzarski
wants to merge
7
commits into
scylladb:main
Choose a base branch
from
muzarski:rename_simple_query_to_unprepared_statement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Unified naming for statements #993
muzarski
wants to merge
7
commits into
scylladb:main
from
muzarski:rename_simple_query_to_unprepared_statement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzarski
force-pushed
the
rename_simple_query_to_unprepared_statement
branch
from
May 6, 2024 21:14
1083be2
to
e1486f3
Compare
See the following report for details: cargo semver-checks output
|
github-actions
bot
added
the
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
label
May 6, 2024
muzarski
force-pushed
the
rename_simple_query_to_unprepared_statement
branch
from
May 15, 2024 13:04
e1486f3
to
fd184dd
Compare
Note: comments/docs are not yet adjusted.
Adjusted the comments and some parameter names, so we follow the unified naming convention.
Still need to be adjusted in some places
muzarski
force-pushed
the
rename_simple_query_to_unprepared_statement
branch
from
May 15, 2024 13:11
fd184dd
to
43703b7
Compare
@roydahan this is a WIP, I don't think I should review it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API-breaking
This might introduce incompatible API changes
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.