Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test PR #953

Conversation

Lorak-mmk
Copy link
Collaborator

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Mar 9, 2024
Copy link

github-actions bot commented Mar 9, 2024

cargo semver-checks detected some API incompatibilities in this PR.
Checked commit: c699113

See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 596453915fcec38e308ae10e0205f2b46f915cb6
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 596453915fcec38e308ae10e0205f2b46f915cb6
     Cloning 596453915fcec38e308ae10e0205f2b46f915cb6
     Parsing scylla v0.12.0 (current)
      Parsed [  19.256s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.866s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.060s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-596453915fcec38e308ae10e0205f2b46f915cb6/db5430a3666a5ea1758cbd5e57ac9f6f57d8d72b/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  37.224s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.680s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.981s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.057s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.754s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

Copy link

github-actions bot commented Mar 9, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 6cf56ff6bc4165ce65711361d617896482ae2eea
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 6cf56ff6bc4165ce65711361d617896482ae2eea
     Cloning 6cf56ff6bc4165ce65711361d617896482ae2eea
     Parsing scylla v0.12.0 (current)
      Parsed [  18.205s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.369s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.061s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-6cf56ff6bc4165ce65711361d617896482ae2eea/7e4982ea8087e62b850220f06ebf709d4b427656/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  35.680s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.845s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.636s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.056s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.575s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

Copy link

github-actions bot commented Mar 9, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 6cf56ff6bc4165ce65711361d617896482ae2eea
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 6cf56ff6bc4165ce65711361d617896482ae2eea
     Cloning 6cf56ff6bc4165ce65711361d617896482ae2eea
     Parsing scylla v0.12.0 (current)
      Parsed [  19.058s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  18.190s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.061s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-6cf56ff6bc4165ce65711361d617896482ae2eea/7e4982ea8087e62b850220f06ebf709d4b427656/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  37.353s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [  10.205s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.840s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.063s] 62 checks; 62 passed, 0 unnecessary
    Finished [  20.147s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch from d28b9dc to b140c13 Compare March 10, 2024 00:36
Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 0bca438d4e7a7a640c17fd3c70daf257bf57fda6
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 0bca438d4e7a7a640c17fd3c70daf257bf57fda6
     Cloning 0bca438d4e7a7a640c17fd3c70daf257bf57fda6
     Parsing scylla v0.12.0 (current)
      Parsed [  20.342s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.881s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.072s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-0bca438d4e7a7a640c17fd3c70daf257bf57fda6/e466e50ccd9768537303514fc9e84579dc7d20fa/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  38.342s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [  10.003s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.772s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.056s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.866s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

Copy link

cargo semver-checks found no API-breaking changes in this PR!

@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch from b140c13 to 80661c5 Compare March 10, 2024 00:47
Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 3762d80c35b576a83456957fc38dd17b38c97123
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 3762d80c35b576a83456957fc38dd17b38c97123
     Cloning 3762d80c35b576a83456957fc38dd17b38c97123
     Parsing scylla v0.12.0 (current)
      Parsed [  17.567s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.420s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.062s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-3762d80c35b576a83456957fc38dd17b38c97123/c15db95ac544c64e594a2757fa3b39b7e8c1db98/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  35.089s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.542s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.478s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.057s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.113s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch from 80661c5 to 8002057 Compare March 10, 2024 00:53
Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev c1ce659b3a6e194432edbe55a718a5a90c3ae3ea
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev c1ce659b3a6e194432edbe55a718a5a90c3ae3ea
     Cloning c1ce659b3a6e194432edbe55a718a5a90c3ae3ea
     Parsing scylla v0.12.0 (current)
      Parsed [  21.111s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  18.303s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.061s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-c1ce659b3a6e194432edbe55a718a5a90c3ae3ea/1818f17333543ef8aa256cc17caecd1f5cfe8d91/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  39.518s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.789s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.747s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.054s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.625s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

1 similar comment
Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev c1ce659b3a6e194432edbe55a718a5a90c3ae3ea
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev c1ce659b3a6e194432edbe55a718a5a90c3ae3ea
     Cloning c1ce659b3a6e194432edbe55a718a5a90c3ae3ea
     Parsing scylla v0.12.0 (current)
      Parsed [  21.111s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  18.303s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.061s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-c1ce659b3a6e194432edbe55a718a5a90c3ae3ea/1818f17333543ef8aa256cc17caecd1f5cfe8d91/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  39.518s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.789s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.747s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.054s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.625s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch 3 times, most recently from 3f050e5 to 7faac18 Compare March 10, 2024 01:25
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-edit-comment branch from a88bf6a to a875d12 Compare March 10, 2024 20:09
@Lorak-mmk Lorak-mmk closed this Mar 10, 2024
@Lorak-mmk Lorak-mmk reopened this Mar 12, 2024
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch from 7faac18 to 43a7f0c Compare March 12, 2024 12:32
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch from 43a7f0c to 06b33f9 Compare March 12, 2024 12:34
@github-actions github-actions bot removed the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Mar 12, 2024
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-edit-comment branch from 5964539 to a875d12 Compare March 12, 2024 13:15
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-test-pr branch from 06b33f9 to c699113 Compare March 12, 2024 13:17
@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Mar 12, 2024
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-edit-comment branch from 5964539 to a875d12 Compare March 12, 2024 13:23
@Lorak-mmk Lorak-mmk closed this Mar 12, 2024
@Lorak-mmk Lorak-mmk deleted the semver-checks-test-pr branch March 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant