Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver checks example PR #920

Closed

Conversation

Lorak-mmk
Copy link
Collaborator

This PR is just to test semver checks CI

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk changed the base branch from main to semver-checks January 24, 2024 16:14
@Lorak-mmk Lorak-mmk closed this Jan 24, 2024
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 56901aa to 36dc413 Compare January 24, 2024 16:18
@Lorak-mmk Lorak-mmk deleted the semver-checks-example branch January 24, 2024 16:18
@Lorak-mmk Lorak-mmk restored the semver-checks-example branch January 24, 2024 16:19
@Lorak-mmk Lorak-mmk reopened this Jan 24, 2024
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 42eb93e to 588df43 Compare January 24, 2024 16:27
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 588df43 to 37d067d Compare January 24, 2024 16:29
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 37d067d to 2e9e00d Compare January 24, 2024 16:36
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 2e9e00d to e05c224 Compare January 24, 2024 21:47
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from e05c224 to 277a2ae Compare January 24, 2024 21:53
@github-actions github-actions bot added semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes and removed semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes labels Jan 24, 2024
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 30565cc to e75b988 Compare January 24, 2024 22:41
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from e75b988 to 6e9f9ab Compare January 24, 2024 22:44
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 6e9f9ab to 8228e28 Compare January 24, 2024 22:54
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 8228e28 to 36ae07f Compare January 24, 2024 22:59
@github-actions github-actions bot added semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes and removed semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes labels Jan 24, 2024
@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Jan 28, 2024
Copy link

detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output ./scripts/semver-checks.sh --baseline-rev 9b58451 + cargo semver-checks -p scylla -p scylla-cql --baseline-rev 9b58451 �[0m�[1m�[32m Cloning�[0m 9b58451 �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current) �[0m�[1m�[32m Parsed�[0m [ 23.018s] (current) �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline) �[0m�[1m�[32m Parsed�[0m [ 20.777s] (baseline) �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change) �[0m�[1m�[31m Checked�[0m [ 0.056s] 58 checks; 57 passed, 1 failed, 0 unnecessary �[0m --- failure struct_missing: pub struct removed or renamed --- �[0m �[0m�[0m�[1mDescription:�[0m A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron �[0m �[0m�[0m�[1mFailed in:�[0m�[0m �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-9b58451c7a2c4b426e4b08d35c56d30cff7ca78c/124e7452d852770b36250b0ae53a905f945ba08b/scylla/src/transport/metrics.rs:32�[0m �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed �[0m�[1m�[32m Finished�[0m [ 43.892s] scylla �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current) �[0m�[1m�[32m Parsed�[0m [ 11.276s] (current) �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline) �[0m�[1m�[32m Parsed�[0m [ 11.523s] (baseline) �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change) �[0m�[1m�[32m Checked�[0m [ 0.050s] 58 checks; 58 passed, 0 unnecessary �[0m�[1m�[32m Finished�[0m [ 22.881s] scylla-cql make: *** [Makefile:53: semver-rev] Error 1

Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output ``` ./scripts/semver-checks.sh --baseline-rev 9936d87 + cargo semver-checks -p scylla -p scylla-cql --baseline-rev 9936d87 �[0m�[1m�[32m Cloning�[0m 9936d87 �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current) �[0m�[1m�[32m Parsed�[0m [ 21.303s] (current) �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline) �[0m�[1m�[32m Parsed�[0m [ 20.829s] (baseline) �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change) �[0m�[1m�[31m Checked�[0m [ 0.058s] 58 checks; 57 passed, 1 failed, 0 unnecessary �[0m --- failure struct_missing: pub struct removed or renamed --- �[0m �[0m�[0m�[1mDescription:�[0m A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron �[0m �[0m�[0m�[1mFailed in:�[0m�[0m �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-9936d8738791ac225269dde541cf70298ac69b94/f416801f4900fe27fc5cb65e8263bfa528244c41/scylla/src/transport/metrics.rs:32�[0m �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed �[0m�[1m�[32m Finished�[0m [ 42.229s] scylla �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current) �[0m�[1m�[32m Parsed�[0m [ 11.227s] (current) �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline) �[0m�[1m�[32m Parsed�[0m [ 11.309s] (baseline) �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change) �[0m�[1m�[32m Checked�[0m [ 0.050s] 58 checks; 58 passed, 0 unnecessary �[0m�[1m�[32m Finished�[0m [ 22.620s] scylla-cql make: *** [Makefile:53: semver-rev] Error 1 ```

Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output ``` ./scripts/semver-checks.sh --baseline-rev 0a12c78 + cargo semver-checks -p scylla -p scylla-cql --baseline-rev 0a12c78 �[0m�[1m�[32m Cloning�[0m 0a12c78 �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current) �[0m�[1m�[32m Parsed�[0m [ 22.717s] (current) �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline) �[0m�[1m�[32m Parsed�[0m [ 20.631s] (baseline) �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change) �[0m�[1m�[31m Checked�[0m [ 0.056s] 58 checks; 57 passed, 1 failed, 0 unnecessary �[0m --- failure struct_missing: pub struct removed or renamed --- �[0m �[0m�[0m�[1mDescription:�[0m A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron �[0m �[0m�[0m�[1mFailed in:�[0m�[0m �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-0a12c78e9e7cde0679ac501eb803df41cefb096a/d329fe131fe35426f71e5e7078470f2947f78c70/scylla/src/transport/metrics.rs:32�[0m �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed �[0m�[1m�[32m Finished�[0m [ 43.447s] scylla �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current) �[0m�[1m�[32m Parsed�[0m [ 11.612s] (current) �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline) �[0m�[1m�[32m Parsed�[0m [ 11.398s] (baseline) �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change) �[0m�[1m�[32m Checked�[0m [ 0.051s] 58 checks; 58 passed, 0 unnecessary �[0m�[1m�[32m Finished�[0m [ 23.094s] scylla-cql make: *** [Makefile:53: semver-rev] Error 1 ```

Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output ```

./scripts/semver-checks.sh --baseline-rev 945b82e

  • cargo semver-checks -p scylla -p scylla-cql --baseline-rev 945b82e
    �[0m�[1m�[32m Cloning�[0m 945b82e
    �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current)
    �[0m�[1m�[32m Parsed�[0m [ 21.595s] (current)
    �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline)
    �[0m�[1m�[32m Parsed�[0m [ 21.310s] (baseline)
    �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change)
    �[0m�[1m�[31m Checked�[0m [ 0.056s] 58 checks; 57 passed, 1 failed, 0 unnecessary
    �[0m
    --- failure struct_missing: pub struct removed or renamed ---
    �[0m
    �[0m�[0m�[1mDescription:�[0m
    A publicly-visible struct cannot be imported by its prior path. A pub use may have been removed, or the struct itself may have been renamed or removed entirely.
    ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
    impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron
    �[0m
    �[0m�[0m�[1mFailed in:�[0m�[0m
    �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-945b82e0f3a59e76dc15fd0a74bd478f3b81a5c6/714bf5eeac27a2c28f59f42e1d40c904757ddab1/scylla/src/transport/metrics.rs:32�[0m
    �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed
    �[0m�[1m�[32m Finished�[0m [ 43.003s] scylla
    �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current)
    �[0m�[1m�[32m Parsed�[0m [ 11.550s] (current)
    �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline)
    �[0m�[1m�[32m Parsed�[0m [ 11.532s] (baseline)
    �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change)
    �[0m�[1m�[32m Checked�[0m [ 0.052s] 58 checks; 58 passed, 0 unnecessary
    �[0m�[1m�[32m Finished�[0m [ 23.169s] scylla-cql
    make: *** [Makefile:53: semver-rev] Error 1
</details>

Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output

./scripts/semver-checks.sh --baseline-rev 59e7485b252889a37740cd151818ac9b1de42746
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 59e7485b252889a37740cd151818ac9b1de42746
     Cloning 59e7485b252889a37740cd151818ac9b1de42746
     Parsing scylla v0.11.1 (current)
      Parsed [  22.102s] (current)
     Parsing scylla v0.11.1 (baseline)
      Parsed [  21.792s] (baseline)
    Checking scylla v0.11.1 -> v0.11.1 (no change)
     Checked [   0.057s] 58 checks; 57 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-59e7485b252889a37740cd151818ac9b1de42746/d0da5fc182a2b46125ce8037ba6d22ffc74a52d7/scylla/src/transport/metrics.rs:32
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  43.995s] scylla
     Parsing scylla-cql v0.0.11 (current)
      Parsed [  12.494s] (current)
     Parsing scylla-cql v0.0.11 (baseline)
      Parsed [  11.858s] (baseline)
    Checking scylla-cql v0.0.11 -> v0.0.11 (no change)
     Checked [   0.053s] 58 checks; 58 passed, 0 unnecessary
    Finished [  24.443s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

Copy link

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 9eefa4e6ee012d5ba4b6da5bff1d995de318ca6d
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 9eefa4e6ee012d5ba4b6da5bff1d995de318ca6d
     Cloning 9eefa4e6ee012d5ba4b6da5bff1d995de318ca6d
     Parsing scylla v0.11.1 (current)
      Parsed [  21.775s] (current)
     Parsing scylla v0.11.1 (baseline)
      Parsed [  20.718s] (baseline)
    Checking scylla v0.11.1 -> v0.11.1 (no change)
     Checked [   0.057s] 58 checks; 57 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-9eefa4e6ee012d5ba4b6da5bff1d995de318ca6d/b300b47247381a12841bdeff7efb7f79ff0cbd98/scylla/src/transport/metrics.rs:32
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  42.590s] scylla
     Parsing scylla-cql v0.0.11 (current)
      Parsed [  11.375s] (current)
     Parsing scylla-cql v0.0.11 (baseline)
      Parsed [  11.391s] (baseline)
    Checking scylla-cql v0.0.11 -> v0.0.11 (no change)
     Checked [   0.053s] 58 checks; 58 passed, 0 unnecessary
    Finished [  22.854s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk force-pushed the semver-checks branch 2 times, most recently from 0502fa1 to 618986c Compare February 1, 2024 23:33
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from 82ef230 to d7aee32 Compare February 1, 2024 23:34
@Lorak-mmk Lorak-mmk force-pushed the semver-checks-example branch from d7aee32 to 4f75496 Compare February 1, 2024 23:44
Copy link

github-actions bot commented Feb 1, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 8fb2355fecbd71a656ad5adc921eef0bdfb1916d
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 8fb2355fecbd71a656ad5adc921eef0bdfb1916d
     Cloning 8fb2355fecbd71a656ad5adc921eef0bdfb1916d
     Parsing scylla v0.11.1 (current)
      Parsed [  22.275s] (current)
     Parsing scylla v0.11.1 (baseline)
      Parsed [  21.137s] (baseline)
    Checking scylla v0.11.1 -> v0.11.1 (no change)
     Checked [   0.056s] 58 checks; 57 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-8fb2355fecbd71a656ad5adc921eef0bdfb1916d/d61bc843d4dcac169cccd45ae07af9c25b277f36/scylla/src/transport/metrics.rs:32
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  43.506s] scylla
     Parsing scylla-cql v0.0.11 (current)
      Parsed [  11.895s] (current)
     Parsing scylla-cql v0.0.11 (baseline)
      Parsed [  11.935s] (baseline)
    Checking scylla-cql v0.0.11 -> v0.0.11 (no change)
     Checked [   0.054s] 58 checks; 58 passed, 0 unnecessary
    Finished [  23.918s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@piodul
Copy link
Collaborator

piodul commented Feb 7, 2024

The PR with the semver checks was merged, so I suppose that this PR which was used to test the semver checks can be closed. I'll go ahead and do it.

@piodul piodul closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants