-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver checks example PR #920
Conversation
f1e1813
to
36dc413
Compare
56901aa
to
36dc413
Compare
36dc413
to
9fc6870
Compare
42eb93e
to
588df43
Compare
9fc6870
to
30c01c5
Compare
588df43
to
37d067d
Compare
30c01c5
to
ff54176
Compare
37d067d
to
2e9e00d
Compare
ff54176
to
275845a
Compare
2e9e00d
to
e05c224
Compare
275845a
to
56aeec0
Compare
e05c224
to
277a2ae
Compare
56aeec0
to
164dfbc
Compare
30565cc
to
e75b988
Compare
164dfbc
to
1903f33
Compare
e75b988
to
6e9f9ab
Compare
1903f33
to
7934014
Compare
6e9f9ab
to
8228e28
Compare
7934014
to
4edfc3c
Compare
8228e28
to
36ae07f
Compare
4edfc3c
to
b560b84
Compare
detected some API incompatibilities in this PR. cargo semver-checks output./scripts/semver-checks.sh --baseline-rev 9b58451 + cargo semver-checks -p scylla -p scylla-cql --baseline-rev 9b58451 �[0m�[1m�[32m Cloning�[0m 9b58451 �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current) �[0m�[1m�[32m Parsed�[0m [ 23.018s] (current) �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline) �[0m�[1m�[32m Parsed�[0m [ 20.777s] (baseline) �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change) �[0m�[1m�[31m Checked�[0m [ 0.056s] 58 checks; 57 passed, 1 failed, 0 unnecessary �[0m --- failure struct_missing: pub struct removed or renamed --- �[0m �[0m�[0m�[1mDescription:�[0m A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron �[0m �[0m�[0m�[1mFailed in:�[0m�[0m �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-9b58451c7a2c4b426e4b08d35c56d30cff7ca78c/124e7452d852770b36250b0ae53a905f945ba08b/scylla/src/transport/metrics.rs:32�[0m �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed �[0m�[1m�[32m Finished�[0m [ 43.892s] scylla �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current) �[0m�[1m�[32m Parsed�[0m [ 11.276s] (current) �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline) �[0m�[1m�[32m Parsed�[0m [ 11.523s] (baseline) �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change) �[0m�[1m�[32m Checked�[0m [ 0.050s] 58 checks; 58 passed, 0 unnecessary �[0m�[1m�[32m Finished�[0m [ 22.881s] scylla-cql make: *** [Makefile:53: semver-rev] Error 1 |
9b58451
to
9936d87
Compare
659a602
to
6eb8841
Compare
9936d87
to
0a12c78
Compare
6eb8841
to
7a18185
Compare
cargo semver-checks output``` ./scripts/semver-checks.sh --baseline-rev 9936d87 + cargo semver-checks -p scylla -p scylla-cql --baseline-rev 9936d87 �[0m�[1m�[32m Cloning�[0m 9936d87 �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current) �[0m�[1m�[32m Parsed�[0m [ 21.303s] (current) �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline) �[0m�[1m�[32m Parsed�[0m [ 20.829s] (baseline) �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change) �[0m�[1m�[31m Checked�[0m [ 0.058s] 58 checks; 57 passed, 1 failed, 0 unnecessary �[0m --- failure struct_missing: pub struct removed or renamed --- �[0m �[0m�[0m�[1mDescription:�[0m A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron �[0m �[0m�[0m�[1mFailed in:�[0m�[0m �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-9936d8738791ac225269dde541cf70298ac69b94/f416801f4900fe27fc5cb65e8263bfa528244c41/scylla/src/transport/metrics.rs:32�[0m �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed �[0m�[1m�[32m Finished�[0m [ 42.229s] scylla �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current) �[0m�[1m�[32m Parsed�[0m [ 11.227s] (current) �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline) �[0m�[1m�[32m Parsed�[0m [ 11.309s] (baseline) �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change) �[0m�[1m�[32m Checked�[0m [ 0.050s] 58 checks; 58 passed, 0 unnecessary �[0m�[1m�[32m Finished�[0m [ 22.620s] scylla-cql make: *** [Makefile:53: semver-rev] Error 1 ``` |
cargo semver-checks output``` ./scripts/semver-checks.sh --baseline-rev 0a12c78 + cargo semver-checks -p scylla -p scylla-cql --baseline-rev 0a12c78 �[0m�[1m�[32m Cloning�[0m 0a12c78 �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (current) �[0m�[1m�[32m Parsed�[0m [ 22.717s] (current) �[0m�[1m�[32m Parsing�[0m scylla v0.11.1 (baseline) �[0m�[1m�[32m Parsed�[0m [ 20.631s] (baseline) �[0m�[1m�[32m Checking�[0m scylla v0.11.1 -> v0.11.1 (no change) �[0m�[1m�[31m Checked�[0m [ 0.056s] 58 checks; 57 passed, 1 failed, 0 unnecessary �[0m --- failure struct_missing: pub struct removed or renamed --- �[0m �[0m�[0m�[1mDescription:�[0m A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/struct_missing.ron �[0m �[0m�[0m�[1mFailed in:�[0m�[0m �[0m struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-0a12c78e9e7cde0679ac501eb803df41cefb096a/d329fe131fe35426f71e5e7078470f2947f78c70/scylla/src/transport/metrics.rs:32�[0m �[0m�[1m�[31m Summary�[0m semver requires new major version: 1 major and 0 minor checks failed �[0m�[1m�[32m Finished�[0m [ 43.447s] scylla �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (current) �[0m�[1m�[32m Parsed�[0m [ 11.612s] (current) �[0m�[1m�[32m Parsing�[0m scylla-cql v0.0.11 (baseline) �[0m�[1m�[32m Parsed�[0m [ 11.398s] (baseline) �[0m�[1m�[32m Checking�[0m scylla-cql v0.0.11 -> v0.0.11 (no change) �[0m�[1m�[32m Checked�[0m [ 0.051s] 58 checks; 58 passed, 0 unnecessary �[0m�[1m�[32m Finished�[0m [ 23.094s] scylla-cql make: *** [Makefile:53: semver-rev] Error 1 ``` |
0a12c78
to
945b82e
Compare
7a18185
to
af13596
Compare
cargo semver-checks output```./scripts/semver-checks.sh --baseline-rev 945b82e
|
945b82e
to
59e7485
Compare
af13596
to
0de0b0e
Compare
cargo semver-checks output
|
59e7485
to
9eefa4e
Compare
0de0b0e
to
82ef230
Compare
cargo semver-checks output
|
0502fa1
to
618986c
Compare
82ef230
to
d7aee32
Compare
b180328
to
d190123
Compare
d7aee32
to
4f75496
Compare
d190123
to
8fb2355
Compare
4f75496
to
20d6848
Compare
cargo semver-checks output
|
8fb2355
to
f6d68d3
Compare
The PR with the semver checks was merged, so I suppose that this PR which was used to test the semver checks can be closed. I'll go ahead and do it. |
This PR is just to test semver checks CI
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.